Starlarkify compute_output_name_prefix_dir#761
Closed
dzbarsky wants to merge 1 commit into
Closed
Conversation
Select arc and non_arc compile output directories directly from the normalized purpose string. Add configured-target coverage for Objective-C ARC and non-ARC object paths.
dzbarsky
changed the title
dzbarsky
marked this pull request as ready for review
June 19, 2026 00:50
lilygorsheneva
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace both
_cc_internal.compute_output_name_prefix_dircalls with a private Starlark helper. The helper returnsnon_arcfor purposes ending in_non_objc_arc,arcfor purposes ending in_objc_arc, and an empty prefix otherwise.compile()normalizes an unset purpose to an empty string before these calls, so the native helper's configuration-mnemonic fallback was not reachable from either rules_cc caller.Configured-target coverage verifies that Objective-C ARC and non-ARC sources retain separate output directories.