Try fixing dynamic library .pyd support for windows#501
Closed
Mizux wants to merge 3 commits into
Closed
Conversation
Mizux
requested review from
armandomontanez,
c-mita,
comius,
hvadehra,
pzembrod and
trybka
as code owners
October 24, 2025 16:27
note: most of this code is disabled unless using bazel 9... ref: * https://github.com/bazelbuild/rules_cc/blob/78a6f281d85b0085d6e485e380b730c551574147/cc/extensions.bzl#L31 * https://github.com/bazelbuild/rules_cc/blob/78a6f281d85b0085d6e485e380b730c551574147/cc/extensions.bzl#L115
Mizux
added a commit
to Mizux/bazel
that referenced
this pull request
Oct 28, 2025
* should fix bazelbuild#17117 * related to bazelbuild/rules_cc#501 * needed to fix pybind/pybind11_bazel#124
Mizux
added a commit
to Mizux/bazel
that referenced
this pull request
Oct 28, 2025
* should fix bazelbuild#17117 * related to bazelbuild/rules_cc#501 * needed to fix pybind/pybind11_bazel#124
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
* should address the example listed in #17117 * related to #501 * needed to fix pybind/pybind11_bazel#124 Closes #27434. PiperOrigin-RevId: 826451549 Change-Id: Ib649bb2e38e057a1a4de6b660f41d4dd13192e06
copybara-service Bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Oct 31, 2025
* should address the example listed in #17117 * related to bazelbuild/rules_cc#501 * needed to fix pybind/pybind11_bazel#124 Closes #27434. PiperOrigin-RevId: 826451549 Change-Id: I79872e654fdc7c73a5e05f3befdc734bd82c4f07
Contributor
Author
|
has been merged as 5a09443 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows
.pydis used as extension for python native module.Currently pybind11_bazel struggle to provide a consistent support on windows since bazel (i.e.
rules_cc) do not support.pydas a shared dynamic library extension...This is a first draft to move in the correct direction to fix:
EDIT: may be blocked by bazelbuild/bazel#17117