Fix generate_modmap: use default generate_modmap#496
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
We previously expose generate_modmap attribute in bazelbuild/bazel@8028655 to support bazelbuild#447 . After migrating to the Starlark implementation, this attribute is no longer needed. Remove the override and rely on the default generate_modmap behavior.
7f72530 to
567c123
Compare
|
Is this missing the attr definition with a default? |
|
Or is there another attr that needs to be added here? |
|
@trybka some error on feedback/copybara . could you take a look? |
here is the definition. rules_cc/cc/common/semantics.bzl Lines 131 to 143 in c645f6b This patch applies the default value to fix the error: |
|
Thanks, looking into it, trying to address the internal checks. |
Copybara Import from bazelbuild/rules_cc#496 BEGIN_PUBLIC Fix generate_modmap: use default generate_modmap (#496) We previously expose generate_modmap attribute in 8028655 to support bazelbuild/rules_cc#447 . After migrating to the Starlark implementation, this attribute is no longer needed. Remove the override and rely on the default generate_modmap behavior. Closes #496 END_PUBLIC PiperOrigin-RevId: 814203331 Change-Id: Ib34a678a0b91c31df086297eb24b56d7ee46cd9a
3 participants
We previously expose generate_modmap attribute in bazelbuild/bazel@8028655 to support #447 . After migrating to the Starlark implementation, this attribute is no longer needed. Remove the override and rely on the default generate_modmap behavior.