Support prefer_pic_for_opt_binaries in linux auto-detecting toolchain#456
Closed
jwnimmer-tri wants to merge 1 commit into
Closed
Support prefer_pic_for_opt_binaries in linux auto-detecting toolchain#456jwnimmer-tri wants to merge 1 commit into
jwnimmer-tri wants to merge 1 commit into
Conversation
jwnimmer-tri
requested review from
armandomontanez,
c-mita,
comius,
pzembrod and
trybka
as code owners
August 10, 2025 15:36
This was referenced Aug 10, 2025
Contributor
Author
|
Is there anything I can do to help get this merged? |
Contributor
Author
|
I hate to ping people directly, but maybe @comius you could help unblock this please? |
Collaborator
|
Sorry this got stuck in review. Will try to help move this along. :) |
armandomontanez
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the demo project example.zip for reproduction.
Without this fix,
foo.ccis compiled twice (once PIC, once non-PIC). With this fix, it is correctly only compiled once because the.bazelrcrequestsbuild --features=prefer_pic_for_opt_binaries.