Add support for specific simulator IDs for iOS tests#648
Add support for specific simulator IDs for iOS tests#648keith wants to merge 1 commit intobazelbuild:masterfrom
Conversation
This allows users to pass configurable simulator UDIDs to run tests with. This allows them to run test jobs on the same simulator without the overhead of creating one each time.
1547e15 to
9124df1
Compare
|
Example usage: string_flag(
name = "ios_simulator_id",
build_setting_default = "",
visibility = ["//visibility:public"],
)
ios_test_runner(
name = "custom_test_runner",
simulator_id = "//:ios_simulator_id",
visibility = ["//visibility:public"],
)I would have put this |
|
Can you file a bug against bazel for rules sets not being able to define these and have them work? We'll get it raised internally. |
|
I filed bazelbuild/bazel#10152 about this. I think in the meantime this would probably still be a fine way to handle this, but I guess it depends on how you feel about the public API changing if this starts working because I initial made |
|
Can you use test arguments for this? we've added support for these in our internal test runner: and invoke it with blaze as such: |
|
I've submitted the |
|
#653 is the better approach |
This allows users to pass configurable simulator UDIDs to run tests
with. This allows them to run test jobs on the same simulator without
the overhead of creating one each time.
Another benefit of this is if you want to setup simulators ahead of time for example for UI tests where you may need to set some simulator defaults to not show iOS' onboarding flows