Fix rules_apple device runner crash on Rapid Security Response versions#2898
Merged
keith merged 1 commit intobazelbuild:mainfrom Mar 26, 2026
Merged
Conversation
Devices running an Apple RSR update report OS versions like "18.3.1 (a)". The rules_apple device runner fails to parse the "(a)" suffix: ValueError: invalid literal for int() with base 10: '1 (a)' Patch rules_apple 4.5.1 to strip non-numeric suffixes from each version component before integer conversion.
lelandjansen
requested review from
aaronsky,
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
|
Works for me, can we merge this? Is this not breaking for everyone? |
keith
approved these changes
Mar 26, 2026
keith
pushed a commit
that referenced
this pull request
Mar 26, 2026
…versions (#2898) Devices running an Apple RSR update report OS versions like "18.3.1 (a)". The rules_apple device runner fails to parse the "(a)" suffix: ``` ValueError: invalid literal for int() with base 10: '1 (a)' ``` Patch rules_apple 4.5.1 to strip non-numeric suffixes from each version component before integer conversion. `bazel run` an iOS application target on a physical device (builds, uploads, and runs) Fixes #2900 (cherry picked from commit 8c999a8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devices running an Apple RSR update report OS versions like "18.3.1 (a)". The rules_apple device runner fails to parse the "(a)" suffix:
Patch rules_apple 4.5.1 to strip non-numeric suffixes from each version component before integer conversion.
Test plan
bazel runan iOS application target on a physical device (builds, uploads, and runs)Fixes #2900