Skip to content

Avoid conflicting actions for xcframework bundles with custom bundle names#2883

Merged
adincebic merged 2 commits intobazelbuild:mainfrom
jschear:js/conflicting_actions_xcframework_custom_bundle_name
Feb 24, 2026
Merged

Avoid conflicting actions for xcframework bundles with custom bundle names#2883
adincebic merged 2 commits intobazelbuild:mainfrom
jschear:js/conflicting_actions_xcframework_custom_bundle_name

Conversation

@jschear
Copy link
Copy Markdown
Contributor

@jschear jschear commented Feb 23, 2026

680c227 (cherry pick of 3276c83) added an output_discriminator parameter to outputs.archive, but we have an early return in the function that doesn't exist upstream; we need to use the output discriminator or multiple actions end up generating the same .framework directory:

ERROR: file 'test/starlark_tests/targets_under_test/apple/ios_dynamic_xcframework_custom_bundle_name_archive-root/CustomBundleName.framework' is generated by these conflicting actions:
Label: //test/starlark_tests/targets_under_test/apple:ios_dynamic_xcframework_custom_bundle_name
RuleClass: apple_xcframework rule
JavaActionClass: class com.google.devtools.build.lib.analysis.actions.StarlarkAction
Configuration: 68611a7bde98cb08f9b317c33b673de2900fd7863f6cb1def6155b02ba61ee8b
Mnemonic: BundleTreeApp
IsShareable: true
Action key: b4a906b098dfaac13e80e35f2b31bf8d183896d0d67839c57f6fae08c12fb35a, a6ce395e810ec8d921f6328938cbf1b0ed46ed0c89395efc24f33efd334fee16
Progress message: Bundling, processing and signing ios_dynamic_xcframework_custom_bundle_name
Action describeKey: Bundling, processing and signing ios_dynamic_xcframework_custom_bundle_name
  Environment variable: XCODE_VERSION_OVERRIDE=26.2.0.17C52
  Environment variable: APPLE_SDK_PLATFORM=MacOSX
  Environment variable: APPLE_SDK_VERSION_OVERRIDE=26.2
  Environment variables taken from the client environment: LD_LIBRARY_PATH
  Environment variables taken from the client environment: PATH
  Execution info: no-sandbox=1
  Execution info: requires-darwin=
  Execution info: supports-xcode-requirements-set=
  Argument: bazel-out/darwin_arm64-opt-exec-ST-9cfc8eebece3/bin/tools/bundletool/bundletool_experimental
  Argument: bazel-out/darwin_x86_64-fastbuild-ST-49cf1622f526/bin/test/starlark_tests/targets_under_test/apple/ios_dynamic_xcframework_custom_bundle_name-intermediates-ios-x86_64-simulator/bundletool_control.json
  Output paths mode: OFF
, Bundling, processing and signing ios_dynamic_xcframework_custom_bundle_name
  Environment variable: XCODE_VERSION_OVERRIDE=26.2.0.17C52
  Environment variable: APPLE_SDK_PLATFORM=MacOSX
  Environment variable: APPLE_SDK_VERSION_OVERRIDE=26.2
  Environment variables taken from the client environment: LD_LIBRARY_PATH
  Environment variables taken from the client environment: PATH
  Execution info: no-sandbox=1
  Execution info: requires-darwin=
  Execution info: supports-xcode-requirements-set=
  Argument: bazel-out/darwin_arm64-opt-exec-ST-9cfc8eebece3/bin/tools/bundletool/bundletool_experimental
  Argument: bazel-out/darwin_x86_64-fastbuild-ST-49cf1622f526/bin/test/starlark_tests/targets_under_test/apple/ios_dynamic_xcframework_custom_bundle_name-intermediates-ios-arm64/bundletool_control.json
  Output paths mode: OFF

PrimaryInput: File:[[<execution_root>]bazel-out/darwin_x86_64-fastbuild-ST-49cf1622f526/bin]test/starlark_tests/targets_under_test/apple/ios_dynamic_xcframework_custom_bundle_name-intermediates-ios-x86_64-simulator/CustomBundleName, File:[[<execution_root>]bazel-out/darwin_x86_64-fastbuild-ST-49cf1622f526/bin]test/starlark_tests/targets_under_test/apple/ios_dynamic_xcframework_custom_bundle_name-intermediates-ios-arm64/CustomBundleName
PrimaryOutput: File:[[<execution_root>]bazel-out/darwin_x86_64-fastbuild-ST-49cf1622f526/bin]test/starlark_tests/targets_under_test/apple/ios_dynamic_xcframework_custom_bundle_name_archive-root/CustomBundleName.framework

@adincebic adincebic merged commit 0385289 into bazelbuild:main Feb 24, 2026
8 checks passed
@jschear jschear deleted the js/conflicting_actions_xcframework_custom_bundle_name branch February 24, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants