run subshells in bundletool_experimental using subprocess API#2866
Merged
aaronsky merged 2 commits intobazelbuild:mainfrom Jan 21, 2026
Merged
run subshells in bundletool_experimental using subprocess API#2866aaronsky merged 2 commits intobazelbuild:mainfrom
aaronsky merged 2 commits intobazelbuild:mainfrom
Conversation
Fixes bazelbuild#2843 use `subprocess.check_call` instead of `os.system` to support stronger security guarantees and block environment variables from the running environment from affecting subprocesses. Fixes usage of rules_apple when using rules_python 1.7.0+.
aaronsky
requested review from
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
luispadron
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2843
use
subprocess.check_callinstead ofos.systemto support strongersecurity guarantees and block environment variables from the running
environment from affecting subprocesses. Fixes usage of rules_apple
when using rules_python 1.7.0+.