Remove unsupported includes parameter for apple_metal_library#2851
Merged
adincebic merged 1 commit intobazelbuild:mainfrom Jan 8, 2026
Merged
Remove unsupported includes parameter for apple_metal_library#2851adincebic merged 1 commit intobazelbuild:mainfrom
adincebic merged 1 commit intobazelbuild:mainfrom
Conversation
mjburghard
requested review from
aaronsky,
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
Contributor
|
@mjburghard is this available upstream? |
mjburghard
force-pushed
the
metal-compile-includes
branch
from
00722e0 to
b97d192
Compare
Contributor
Author
|
@adincebic I do not see anything metal related on the upstream branch |
adincebic
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
includesparameter was never properly supported and is not forwarded to the Metal compiler.