Move COLLECT_PROFDATA check back outside of COVERAGE check#2829
Merged
brentleyjones merged 1 commit intomasterfrom Nov 19, 2025
Merged
Conversation
It was originally added as a way to collect coverage data regardless of `bazel coverage` usage. Regressed with d20fc44. Signed-off-by: Brentley Jones <[email protected]>
brentleyjones
requested review from
aaronsky,
adincebic,
keith,
luispadron and
mattrobmattrob
as code owners
adincebic
approved these changes
Nov 19, 2025
aaronsky
approved these changes
Nov 19, 2025
mattrobmattrob
approved these changes
Nov 19, 2025
brentleyjones
deleted the
bj/move-collect_profdata-check-back-outside-of-coverage-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was originally added as a way to collect coverage data regardless of
bazel coverageusage. Regressed with d20fc44.