Simulator: Always close before trying to launch#2819
Merged
adincebic merged 2 commits intobazelbuild:masterfrom Nov 15, 2025
Merged
Simulator: Always close before trying to launch#2819adincebic merged 2 commits intobazelbuild:masterfrom
adincebic merged 2 commits intobazelbuild:masterfrom
Conversation
rockbruno
requested review from
aaronsky,
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
adincebic
approved these changes
Nov 14, 2025
brentleyjones
approved these changes
Nov 14, 2025
luispadron
approved these changes
Nov 14, 2025
Contributor
|
Looks like test timeout was unrelated to this change. Merging now. We can revert if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that the simulator launching logic always tries to close existing instances of the app before trying to launch. This is to match Xcode's behavior when trying to re-debug the app. Without this, I've experienced some cases where the simulator would either get confused and do nothing or re-attach without restarting the app.