Remove "conflict detection" for the hdrs attribute and the generated umbrella header to consistently allow users to override the umbrella header via public_hdrs or hdrs, where available.#2810
Conversation
…umbrella header to consistently allow users to override the umbrella header via public_hdrs or hdrs, where available. PiperOrigin-RevId: 553817824 (cherry picked from commit 94c1a7f)
keith
requested review from
aaronsky,
adincebic,
brentleyjones,
luispadron and
mattrobmattrob
as code owners
keith
referenced
this pull request
Nov 11, 2025
…umbrella header to consistently allow users to override the umbrella header via public_hdrs or hdrs, where available. PiperOrigin-RevId: 553817824
aaronsky
approved these changes
Nov 11, 2025
adincebic
approved these changes
Nov 11, 2025
luispadron
approved these changes
Nov 11, 2025
…attribute-and-the-generated-umbrella-header-to-consistently-allow-users-to-override-the-umbrella-header-via-public_hdrs-or-hdrs-where-available
keith
deleted the
ks/remove-conflict-detection-for-the-hdrs-attribute-and-the-generated-umbrella-header-to-consistently-allow-users-to-override-the-umbrella-header-via-public_hdrs-or-hdrs-where-available
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 553817824
(cherry picked from commit 94c1a7f)