Merged
Conversation
adincebic
changed the title
adincebic
force-pushed
the
adin/align-resource_actions-with-upstream
branch
2 times, most recently
from
c701f3f to
998a982
Compare
…g analysis time logic to set them as necessary. PiperOrigin-RevId: 779168158 (cherry picked from commit f83c6e8)
…happy paths of watchOS and macOS icon bundles with tests. PiperOrigin-RevId: 779317298 (cherry picked from commit a46ce2f)
PiperOrigin-RevId: 779343706 (cherry picked from commit a8fe45c)
…ation of provided icons and launch images, moving the actual validation to actool.bzl. In the process, we consider more corner cases like forbidding legacy icon assets in platforms that should never use them, if provided via resources from deps and not just top level attributes. PiperOrigin-RevId: 780974060 (cherry picked from commit 46824ac)
… composer bundles for Xcode 26 beta 2. PiperOrigin-RevId: 781044757 (cherry picked from commit 7a371a5)
…ts of Xcode 26 beta 3. This version no longer generates a set of icons for previous versions of iOS/macOS when given an Icon Composer bundle and no icons for an asset catalog. PiperOrigin-RevId: 781063789 (cherry picked from commit 8721963)
…ppIcons in xcassets if they are targeting a minimum_os_version prior to 26.0 when available. PiperOrigin-RevId: 781437521 (cherry picked from commit b286806)
… visible warning, but not an error, for Xcode 26 compatibility. PiperOrigin-RevId: 781523933 (cherry picked from commit 4c37c0c)
Keeping rules flexible to accomodate users on previous betas at the moment, leaving the "actool" warnings and errors alone for the time being. PiperOrigin-RevId: 786434481 (cherry picked from commit 3906137)
…eta 5. PiperOrigin-RevId: 793627429 (cherry picked from commit c345148)
…e 26 betas. PiperOrigin-RevId: 804411520 (cherry picked from commit 34f1048)
…6 beta 5 and later; this was only used by the Xcode 26 betas up through beta 4. PiperOrigin-RevId: 804575923 (cherry picked from commit e21ad32)
PiperOrigin-RevId: 805044535 (cherry picked from commit 239c0e9)
adincebic
force-pushed
the
adin/align-resource_actions-with-upstream
branch
from
998a982 to
d95588a
Compare
aaronsky
approved these changes
Nov 12, 2025
adincebic
referenced
this pull request
Nov 12, 2025
…g analysis time logic to set them as necessary. PiperOrigin-RevId: 779168158
adincebic
referenced
this pull request
Nov 12, 2025
…happy paths of watchOS and macOS icon bundles with tests. PiperOrigin-RevId: 779317298
adincebic
referenced
this pull request
Nov 12, 2025
…ation of provided icons and launch images, moving the actual validation to actool.bzl. In the process, we consider more corner cases like forbidding legacy icon assets in platforms that should never use them, if provided via resources from deps and not just top level attributes. PiperOrigin-RevId: 780974060
adincebic
referenced
this pull request
Nov 12, 2025
… composer bundles for Xcode 26 beta 2. PiperOrigin-RevId: 781044757
adincebic
referenced
this pull request
Nov 12, 2025
…ts of Xcode 26 beta 3. This version no longer generates a set of icons for previous versions of iOS/macOS when given an Icon Composer bundle and no icons for an asset catalog. PiperOrigin-RevId: 781063789
adincebic
referenced
this pull request
Nov 12, 2025
…ppIcons in xcassets if they are targeting a minimum_os_version prior to 26.0 when available. PiperOrigin-RevId: 781437521
adincebic
referenced
this pull request
Nov 12, 2025
… visible warning, but not an error, for Xcode 26 compatibility. PiperOrigin-RevId: 781523933
adincebic
referenced
this pull request
Nov 12, 2025
Keeping rules flexible to accomodate users on previous betas at the moment, leaving the "actool" warnings and errors alone for the time being. PiperOrigin-RevId: 786434481
adincebic
referenced
this pull request
Nov 12, 2025
…6 beta 5 and later; this was only used by the Xcode 26 betas up through beta 4. PiperOrigin-RevId: 804575923
adincebic
pushed a commit
that referenced
this pull request
Dec 12, 2025
#2804 introduced in issue where comparisons with `platform_type` are always negative. `platform_type` is of type `apple_platform_type` and cannot be compared with `string` directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks: