Support creating Info.plist for inner framework apple_static_xcframework#2791
Merged
keith merged 4 commits intobazelbuild:masterfrom Nov 13, 2025
Merged
Conversation
louwers
requested review from
aaronsky,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
keith
approved these changes
Oct 30, 2025
Member
keith
left a comment
keith
left a comment
There was a problem hiding this comment.
lgtm, there's probably an argument for requiring this in the future like the dynamic version does, but this seems nicer if you don't need it in all cases(?)
Contributor
Author
|
@keith Yes, but I figured it makes sense to keep it backward compatible for now. |
|
@keith are there any chances this PR to be merged? We (eng from Lyft) would like to move MapLibre for open source static framework for iOS. |
- Introduced `bundle_id` attribute to specify a reverse-DNS path for embedded frameworks. - Added `infoplists` attribute to allow merging of .plist files when a bundle ID is provided. - Updated implementation to collect top-level Info.plists based on the presence of a bundle ID. - Added tests to verify Info.plist generation for static XCFrameworks with a bundle ID.
keith
force-pushed
the
static-xcframework-info-plist
branch
from
960050b to
e97fd8f
Compare
Member
|
rebased, looks like needs a ci regen, should be green after |
Signed-off-by: Aaron Sky <[email protected]>
aaronsky
approved these changes
Nov 13, 2025
luispadron
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will generate an
Info.plistfor inner.frameworkdirectories inside a static XCFramework wheninfoplistsandbundle_idis provided (kept optional for backward compatibility).Closes #2456