environment_plist: lower the entire --platform string#2765
Merged
keith merged 1 commit intobazelbuild:masterfrom Aug 15, 2025
Merged
environment_plist: lower the entire --platform string#2765keith merged 1 commit intobazelbuild:masterfrom
keith merged 1 commit intobazelbuild:masterfrom
Conversation
The `xcrun --sdk` argument expects only lowercase letters and numbers. SDK version is usually just numbers, but in the exceptional case where it also has letters, we need to .lower() the entire string that we pass, and not just the platform name. We're slightly modifying `_environment_plist_impl()` in that commit to support that use-case.
ma-oli
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
keith
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
xcrun --sdkargument expects only lowercase letters and numbers. SDK version is usually just numbers, but in the exceptional case where it also has letters, we need to .lower() the entire string that we pass, and not just the platform name. We're slightly modifying_environment_plist_impl()in that commit to support that use-case.