transform XCTRunner.app Info.plist to xml before sed'ing it#2763
Merged
aaronsky merged 1 commit intobazelbuild:masterfrom Aug 6, 2025
Merged
Conversation
aaronsky
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
adincebic
approved these changes
Aug 6, 2025
luispadron
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the new case in Xcode 26 where the Info.plist in the XCTRunner.app is a binary plist, rather than an XML plist in Xcode 16. Coercing the plist to xml works whether or not it is originally a plist, and Xcode 16 handles the case of a binary plist adequately.
Also willing to rework this to do keypath-based substitution instead of using sed, though the sed approach has definitely proven resilient up to now.