Make AppIntentsMetadataProcessor outputs deterministic#2761
Merged
adincebic merged 5 commits intobazelbuild:mainfrom Jan 11, 2026
Merged
Conversation
thelvis4
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
thelvis4
changed the title
aaronsky
reviewed
Aug 6, 2025
thelvis4
force-pushed
the
make-AppIntentsMetadataProcessor-output-deterministic
branch
from
907e3ce to
27a9d2b
Compare
adincebic
force-pushed
the
make-AppIntentsMetadataProcessor-output-deterministic
branch
from
ee839a7 to
ce3aa36
Compare
adincebic
approved these changes
Nov 16, 2025
Contributor
adincebic
left a comment
adincebic
left a comment
There was a problem hiding this comment.
Thanks for fixing this.
**Context** bazelbuild#2760 Similar to https://github.sc-corp.net/Snapchat/rules_apple/pull/46, this sorts the keys of `version.json` file generated by the `AppIntentsMetadataProcessor` which also has non-deterministic key order. --- Automatic squash commit from https://github.sc-corp.net/Snapchat/rules_apple/pull/47 Cooled by araifura
adincebic
force-pushed
the
make-AppIntentsMetadataProcessor-output-deterministic
branch
from
ce3aa36 to
cfdae97
Compare
Contributor
adincebic
force-pushed
the
make-AppIntentsMetadataProcessor-output-deterministic
branch
from
cfdae97 to
5accc64
Compare
aaronsky
approved these changes
Jan 11, 2026
thelvis4
deleted the
make-AppIntentsMetadataProcessor-output-deterministic
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed that
xcrun appintentsmetadataprocessorproduces non-deterministicMetadata.appintents/extract.actionsdataandMetadata.appintents/version.jsonJSON outputs (unstable json key order) resulting in different hashes for them when building the same target on different machines.Changes
Sort the keys of
Metadata.appintents/extract.actionsdataandMetadata.appintents/extract.actionsdatadirectory tree output using/usr/bin/python3 -m json.toolto make it deterministic.Filed Apple Feedback:
FB19585633Fixes #2760