Merged
Conversation
keith
referenced
this pull request
Jul 7, 2022
https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes > Starting with Xcode 14, bitcode is no longer required for watchOS and tvOS applications, and the App Store no longer accepts bitcode submissions from Xcode 14. > > Xcode no longer builds bitcode by default and generates a warning message if a project explicitly enables bitcode: “Building with bitcode is deprecated. Please update your project and/or target settings to disable bitcode.” The capability to build with bitcode will be removed in a future Xcode release. IPAs that contain bitcode will have the bitcode stripped before being submitted to the App Store. Debug symbols for past bitcode submissions remain available for download. (86118779) RELNOTES: None PiperOrigin-RevId: 453277394
https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes > Starting with Xcode 14, bitcode is no longer required for watchOS and tvOS applications, and the App Store no longer accepts bitcode submissions from Xcode 14. > > Xcode no longer builds bitcode by default and generates a warning message if a project explicitly enables bitcode: “Building with bitcode is deprecated. Please update your project and/or target settings to disable bitcode.” The capability to build with bitcode will be removed in a future Xcode release. IPAs that contain bitcode will have the bitcode stripped before being submitted to the App Store. Debug symbols for past bitcode submissions remain available for download. (86118779) RELNOTES: None PiperOrigin-RevId: 453277394 (cherry picked from commit 14be0fd)
Bitcode is no longer supported for Xcode 14 and later. App Store support for uploads from Xcode prior to 14.1 will no longer be allowed after April 25. PiperOrigin-RevId: 527298659 (cherry picked from commit b31a1cb)
keith
force-pushed
the
ks/remove-all-bitcode-related-tests
branch
from
a4b364d to
d0d7262
Compare
I imagine a new Xcode version will just remove this from the stub
keith
referenced
this pull request
May 4, 2023
Bitcode is no longer supported for Xcode 14 and later. App Store support for uploads from Xcode prior to 14.1 will no longer be allowed after April 25. PiperOrigin-RevId: 527298659
keith
requested review from
BalestraPatrick,
brentleyjones,
mattrobmattrob,
segiddins and
thii
as code owners
Member
Author
mattrobmattrob
approved these changes
May 4, 2023
Contributor
mattrobmattrob
left a comment
mattrobmattrob
left a comment
There was a problem hiding this comment.
What's the plan for things like @build_bazel_rules_apple//apple/internal:bitcode_support.bzl? Shouldn't all callers of something like bitcode_support.bitcode_mode_string(...) just always assume it's none now and strip bitcode, if it's present?
Member
Author
|
yea probably, just wanted to do the minimum to get us green again |
mattrobmattrob
added a commit
to mattrobmattrob/rules_ios
that referenced
this pull request
Jun 1, 2023
Handle bazelbuild/rules_apple#1534 and update `rules_apple` to https://github.com/bazelbuild/rules_apple/releases/tag/2.3.0 (bazelbuild/rules_apple@915ac30). Signed-off-by: Matt Robinson <[email protected]>
mattrobmattrob
added a commit
to bazel-ios/rules_ios
that referenced
this pull request
Jun 1, 2023
Handle bazelbuild/rules_apple#1534 and update `rules_apple` to https://github.com/bazelbuild/rules_apple/releases/tag/2.3.0 (bazelbuild/rules_apple@915ac30). Signed-off-by: Matt Robinson <[email protected]>
nataliejameson
pushed a commit
to discord/rules_ios
that referenced
this pull request
Aug 13, 2024
Handle bazelbuild/rules_apple#1534 and update `rules_apple` to https://github.com/bazelbuild/rules_apple/releases/tag/2.3.0 (bazelbuild/rules_apple@915ac30). Signed-off-by: Matt Robinson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Xcode 14.1 is the minimum supported to the App Store, and Xcode
14.0 dropped support for bitcode, we don't need to handle these flags
anymore.
Closes #1956