Add @loader_path/Frameworks rpath when building dynamic xcframeworks.

allevato · swiple-rules-gardener · commit cedcaecd8fa3 · 2026-01-07T13:37:17.000-08:00
PiperOrigin-RevId: 853394275
diff --git a/apple/internal/xcframework_rules.bzl b/apple/internal/xcframework_rules.bzl
@@ -1358,6 +1358,7 @@ def _apple_xcframework_impl(ctx):
         # While different, these resolve to the same paths relative to their respective
         # executables. Only macOS (which is not yet supported) is an outlier.
         "-Wl,-rpath,@executable_path/Frameworks",
+        "-Wl,-rpath,@loader_path/Frameworks",
         "-install_name",
         "@rpath/{name}.framework/{name}".format(
             name = bundle_name,
diff --git a/test/starlark_tests/apple_xcframework_tests.bzl b/test/starlark_tests/apple_xcframework_tests.bzl
@@ -199,6 +199,7 @@ def apple_xcframework_test_suite(name):
         macho_load_commands_contain = [
             "name @rpath/ios_dynamic_xcframework.framework/ios_dynamic_xcframework (offset 24)",
             "path @executable_path/Frameworks (offset 12)",
+            "path @loader_path/Frameworks (offset 12)",
         ],
         contains = [
             "$BUNDLE_ROOT/ios-arm64/ios_dynamic_xcframework.framework/Headers/shared.h",
@@ -220,6 +221,7 @@ def apple_xcframework_test_suite(name):
         macho_load_commands_contain = [
             "name @rpath/ios_dynamic_xcframework.framework/ios_dynamic_xcframework (offset 24)",
             "path @executable_path/Frameworks (offset 12)",
+            "path @loader_path/Frameworks (offset 12)",
         ],
         contains = [
             "$BUNDLE_ROOT/ios-x86_64-simulator/ios_dynamic_xcframework.framework/Headers/shared.h",
@@ -241,6 +243,7 @@ def apple_xcframework_test_suite(name):
         macho_load_commands_contain = [
             "name @rpath/ios_dynamic_lipoed_xcframework.framework/ios_dynamic_lipoed_xcframework (offset 24)",
             "path @executable_path/Frameworks (offset 12)",
+            "path @loader_path/Frameworks (offset 12)",
         ],
         contains = [
             "$BUNDLE_ROOT/ios-arm64_arm64e/ios_dynamic_lipoed_xcframework.framework/Headers/shared.h",
@@ -262,6 +265,7 @@ def apple_xcframework_test_suite(name):
         macho_load_commands_contain = [
             "name @rpath/ios_dynamic_lipoed_xcframework.framework/ios_dynamic_lipoed_xcframework (offset 24)",
             "path @executable_path/Frameworks (offset 12)",
+            "path @loader_path/Frameworks (offset 12)",
         ],
         contains = [
             "$BUNDLE_ROOT/ios-arm64_x86_64-simulator/ios_dynamic_lipoed_xcframework.framework/Headers/shared.h",
@@ -703,6 +707,7 @@ def apple_xcframework_test_suite(name):
         macho_load_commands_contain = [
             "name @rpath/tvos_dynamic_xcframework.framework/tvos_dynamic_xcframework (offset 24)",
             "path @executable_path/Frameworks (offset 12)",
+            "path @loader_path/Frameworks (offset 12)",
         ],
         tags = [name],
     )
@@ -715,6 +720,7 @@ def apple_xcframework_test_suite(name):
         macho_load_commands_contain = [
             "name @rpath/tvos_dynamic_xcframework.framework/tvos_dynamic_xcframework (offset 24)",
             "path @executable_path/Frameworks (offset 12)",
+            "path @loader_path/Frameworks (offset 12)",
         ],
         tags = [name],
     )
@@ -727,6 +733,7 @@ def apple_xcframework_test_suite(name):
         macho_load_commands_contain = [
             "name @rpath/tvos_dynamic_xcframework.framework/tvos_dynamic_xcframework (offset 24)",
             "path @executable_path/Frameworks (offset 12)",
+            "path @loader_path/Frameworks (offset 12)",
         ],
         tags = [name],
     )
@@ -741,6 +748,7 @@ def apple_xcframework_test_suite(name):
         macho_load_commands_contain = [
             "name @rpath/visionos_dynamic_xcframework.framework/visionos_dynamic_xcframework (offset 24)",
             "path @executable_path/Frameworks (offset 12)",
+            "path @loader_path/Frameworks (offset 12)",
         ],
         tags = [name],
     )
@@ -753,6 +761,7 @@ def apple_xcframework_test_suite(name):
         macho_load_commands_contain = [
             "name @rpath/visionos_dynamic_xcframework.framework/visionos_dynamic_xcframework (offset 24)",
             "path @executable_path/Frameworks (offset 12)",
+            "path @loader_path/Frameworks (offset 12)",
         ],
         tags = [name],
     )
@@ -765,6 +774,7 @@ def apple_xcframework_test_suite(name):
         macho_load_commands_contain = [
             "name @rpath/visionos_dynamic_xcframework.framework/visionos_dynamic_xcframework (offset 24)",
             "path @executable_path/Frameworks (offset 12)",
+            "path @loader_path/Frameworks (offset 12)",
         ],
         tags = [name],
     )
