Skip to content

Commit 796fae6

Browse files
update CREATE_XCRESULT_BUNDLE comment (#1952)
Users should set `create_xcresult_bundle` on the runner instead --------- Co-authored-by: Matt Robinson <[email protected]>
1 parent 213e3ee commit 796fae6

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

apple/testing/default_runner/ios_xctestrun_runner.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,8 @@ ios_unit_test(
182182
```
183183
184184
If you would like this test runner to generate xcresult bundles for your tests,
185-
pass `--test_env=CREATE_XCRESULT_BUNDLE=1`
185+
pass `--test_env=CREATE_XCRESULT_BUNDLE=1`. It is preferable to use the
186+
`create_xcresult_bundle` on the test runner itself instead of this parameter.
186187
187188
This rule automatically handles running x86_64 tests on arm64 hosts. The only
188189
exception is that if you want to generate xcresult bundles or run tests in

doc/rules-ios.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,8 @@ ios_unit_test(
660660
```
661661

662662
If you would like this test runner to generate xcresult bundles for your tests,
663-
pass `--test_env=CREATE_XCRESULT_BUNDLE=1`
663+
pass `--test_env=CREATE_XCRESULT_BUNDLE=1`. It is preferable to use the
664+
`create_xcresult_bundle` on the test runner itself instead of this parameter.
664665

665666
This rule automatically handles running x86_64 tests on arm64 hosts. The only
666667
exception is that if you want to generate xcresult bundles or run tests in

0 commit comments

Comments
 (0)