Repository navigation
Conversation
Signed-off-by: David Sarkisyan <[email protected]>
Collaborator
|
Thanks for the PR, we fixed it here: #676 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a unified single-file download fails before recording moved-byte metadata,
afterDownloadcurrently skips the waiting requests. The callers then wait until their contexts are canceled and do not receive the original CAS error.This change supplies zero-moved metadata with the requested size, allowing the existing response path to notify every waiter with the original error. The regression uses a missing fake-CAS blob and verifies that
DownloadActionOutputsreturnsNotFoundbefore its deadline.This addresses the stuck-client failure mode described in issue #37.
Testing
go test ./go/pkg/client -count=1go test -race ./go/pkg/client -run '^TestUnifiedDownloadReturnsCASErrors$' -count=3go vet ./go/pkg/clientgofmtandgit diff --check