Add "Representing repeatable Starlark flags as config.string_list"#248
Merged
gregestren merged 1 commit intobazelbuild:mainfrom Mar 8, 2022
Conversation
Contributor
|
Let's add an entry in https://github.com/bazelbuild/proposals/blob/main/README.md. I'll approve this as a pending proposal (still to be reviewed), and by policy you can sent out an announcement to bazel-dev. |
fmeum
force-pushed
the
2022-03-06-representation-of-repeatable-starlark-flags
branch
from
988bdc6 to
16c9d1f
Compare
Contributor
Author
|
@gregestren Added an entry to the list. Is the category correct? Should I send out the announcement once the PR has been merged? |
Contributor
|
Yes, please (and CC me). It seems kind of silly that the design process shows checking it in as a draft, then basically immediately changing it to "under review". Or am I reading that flow chart wrong? |
gregestren
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal was requested by @gregestren in bazelbuild/bazel#14911 (comment).