Use Visual C++ 2022 by default#1770
Merged
meteorcloudy merged 1 commit intobazelbuild:masterfrom Nov 2, 2023
Merged
Conversation
fmeum
requested review from
Wyverald,
fweikert and
meteorcloudy
as code owners
Contributor
Author
|
Manual test passed in bazelbuild/bazel#19485 |
meteorcloudy
approved these changes
Nov 2, 2023
meteorcloudy
approved these changes
Nov 2, 2023
|
Are all the CI machines updated? rules_pkg started to fail at head right after this. |
Contributor
|
Hey @fmeum it seems like this broke projects like rules_pkg: any recommendation what change we should make? |
Contributor
Author
|
I don't see a difference in the |
Member
Member
|
cc toolchain detection in |
meteorcloudy
added a commit
to bazelbuild/rules_pkg
that referenced
this pull request
Nov 7, 2023
The cc toolchain autoconfig is out of sync from Bazel and doesn't work with VS2022. Related: bazelbuild/continuous-integration#1770
Member
aiuto
pushed a commit
to bazelbuild/rules_pkg
that referenced
this pull request
Nov 7, 2023
* Don't load cc toolchain from rules_cc The cc toolchain autoconfig is out of sync from Bazel and doesn't work with VS2022. Related: bazelbuild/continuous-integration#1770 * Fixes centos7
fweikert
pushed a commit
to fweikert/continuous-integration
that referenced
this pull request
Mar 27, 2025
fweikert
pushed a commit
to fweikert/continuous-integration
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.