Choose Xcode version based on MacOS version#1542
Merged
fweikert merged 1 commit intobazelbuild:masterfrom Jan 31, 2023
Merged
Conversation
Due to an ongoing infra update we're operating multiple different versions of MacOS, which unfortunately are not all compatible with the same Xcode versions. Consequently, this commit improves the Xcode version selection logic by determining the Xcode version based on the MacOS version. This behavior can be avoided by explicitly specifying an Xcode version in the task config. Eventually we will run the same versions on all machines in the MacOS fleet. Progress towards bazelbuild#1540
copybara-service Bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Feb 1, 2023
[#1542](bazelbuild/continuous-integration#1542) added some logic to pick the best Xcode version based on the MacOS version (which unfortunately differs between machines). This should fix the failures related to [#1540](bazelbuild/continuous-integration#1540) in both pre- and post-submit pipelines. PiperOrigin-RevId: 506279891 Change-Id: I4f22c1bfdf616a2cc4d06a1e6a242556c3863882
fweikert
added a commit
that referenced
this pull request
Feb 1, 2023
Contributor
|
Should this and #1543 be merged into release-6.1.0? |
Contributor
|
Nevermind, I thought this was in bazelbuild/bazel for some reason. Disregard my previous comment. |
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this pull request
Feb 2, 2023
[bazelbuild#1542](bazelbuild/continuous-integration#1542) added some logic to pick the best Xcode version based on the MacOS version (which unfortunately differs between machines). This should fix the failures related to [bazelbuild#1540](bazelbuild/continuous-integration#1540) in both pre- and post-submit pipelines. PiperOrigin-RevId: 506279891 Change-Id: I4f22c1bfdf616a2cc4d06a1e6a242556c3863882
ted-xie
pushed a commit
to ted-xie/bazel
that referenced
this pull request
Feb 2, 2023
[bazelbuild#1542](bazelbuild/continuous-integration#1542) added some logic to pick the best Xcode version based on the MacOS version (which unfortunately differs between machines). This should fix the failures related to [bazelbuild#1540](bazelbuild/continuous-integration#1540) in both pre- and post-submit pipelines. PiperOrigin-RevId: 506279891 Change-Id: I4f22c1bfdf616a2cc4d06a1e6a242556c3863882
fweikert
added a commit
to fweikert/continuous-integration
that referenced
this pull request
Feb 6, 2023
bazelbuild#1542 relied on platform.mac_ver() to detect the MacOS version, which did not work as expected. Consequently, the previous PR led the CI to activate an incorrect version of Xcode. This behavior has been fixed by this change. Related to bazelbuild#1431.
fweikert
added a commit
that referenced
this pull request
Feb 7, 2023
#1542 relied on platform.mac_ver() to detect the MacOS version, which did not work as expected. Consequently, the previous PR led the CI to activate an incorrect version of Xcode. This behavior has been fixed by this change. Related to #1431. Users can still request a specific Xcode version in their CI config.
hvadehra
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Feb 14, 2023
[#1542](bazelbuild/continuous-integration#1542) added some logic to pick the best Xcode version based on the MacOS version (which unfortunately differs between machines). This should fix the failures related to [#1540](bazelbuild/continuous-integration#1540) in both pre- and post-submit pipelines. PiperOrigin-RevId: 506279891 Change-Id: I4f22c1bfdf616a2cc4d06a1e6a242556c3863882
fmeum
pushed a commit
to fmeum/continuous-integration
that referenced
this pull request
Dec 10, 2023
Due to an ongoing infra update we're operating multiple different versions of MacOS, which unfortunately are not all compatible with the same Xcode versions. Consequently, this commit improves the Xcode version selection logic by determining the Xcode version based on the MacOS version. This behavior can be avoided by explicitly specifying an Xcode version in the task config. Eventually we will run the same versions on all machines in the MacOS fleet. Progress towards bazelbuild#1540
fmeum
pushed a commit
to fmeum/continuous-integration
that referenced
this pull request
Dec 10, 2023
The problem has been solved by bazelbuild#1542 and bazelbuild#1543. Fixes bazelbuild#1540
fmeum
pushed a commit
to fmeum/continuous-integration
that referenced
this pull request
Dec 10, 2023
bazelbuild#1542 relied on platform.mac_ver() to detect the MacOS version, which did not work as expected. Consequently, the previous PR led the CI to activate an incorrect version of Xcode. This behavior has been fixed by this change. Related to bazelbuild#1431. Users can still request a specific Xcode version in their CI config.
fweikert
added a commit
to fweikert/continuous-integration
that referenced
this pull request
Mar 27, 2025
Due to an ongoing infra update we're operating multiple different versions of MacOS, which unfortunately are not all compatible with the same Xcode versions. Consequently, this commit improves the Xcode version selection logic by determining the Xcode version based on the MacOS version. This behavior can be avoided by explicitly specifying an Xcode version in the task config. Eventually we will run the same versions on all machines in the MacOS fleet. Progress towards bazelbuild#1540
fweikert
added a commit
to fweikert/continuous-integration
that referenced
this pull request
Mar 27, 2025
The problem has been solved by bazelbuild#1542 and bazelbuild#1543. Fixes bazelbuild#1540
fweikert
added a commit
to fweikert/continuous-integration
that referenced
this pull request
Mar 27, 2025
bazelbuild#1542 relied on platform.mac_ver() to detect the MacOS version, which did not work as expected. Consequently, the previous PR led the CI to activate an incorrect version of Xcode. This behavior has been fixed by this change. Related to bazelbuild#1431. Users can still request a specific Xcode version in their CI config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an ongoing infra update we're operating multiple different versions of MacOS, which unfortunately are not all compatible with the same Xcode versions. Consequently, this commit improves the Xcode version selection logic by determining the Xcode version based on the MacOS version.
This behavior can be avoided by explicitly specifying an Xcode version in the task config.
Eventually we will run the same versions on all machines in the MacOS fleet.
Progress towards #1540