Skip to content

Update clang version for envoy#1502

Closed
keith wants to merge 1 commit intobazelbuild:masterfrom
keith:ks/update-clang-version-for-envoy
Closed

Update clang version for envoy#1502
keith wants to merge 1 commit intobazelbuild:masterfrom
keith:ks/update-clang-version-for-envoy

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Nov 30, 2022

clang-10 is a bit old now, and envoy HEAD no longer compiles with it because of envoyproxy/envoy#23891

@keith
Update clang version for envoy
e071846 
clang-10 is a bit old now, and envoy HEAD no longer compiles with it
because of envoyproxy/envoy#23891
@keith
Copy link
Copy Markdown
Member Author

keith commented Nov 30, 2022

@meteorcloudy is it possible to run this before merging to see if it fixes https://buildkite.com/bazel/envoy/builds/2118#01849d85-5a46-4688-9dc4-2e30d6659b1b ?

This was referenced Nov 30, 2022
Closed
Closed
@meteorcloudy
Copy link
Copy Markdown
Member

meteorcloudy commented Dec 1, 2022

I think we should update the presubmit.yml file in the enovy repo instead: https://github.com/envoyproxy/envoy/blob/main/.bazelci/presubmit.yml#L21

This config file in the CI repo is no longer used.

@meteorcloudy
Copy link
Copy Markdown
Member

meteorcloudy commented Dec 1, 2022

OK, it is still used in

continuous-integration/buildkite/bazelci.py

Line 190 in 08f1dab

"http_config": "https://raw.githubusercontent.com/bazelbuild/continuous-integration/master/pipelines/envoy.yml",
, but we should also update this to the Envoy one.

@meteorcloudy
Copy link
Copy Markdown
Member

meteorcloudy commented Dec 1, 2022 •
edited
Loading

I think we should update the presubmit.yml file in the enovy repo instead:

And then we can test the change before merging if you push the change to a branch in the envoy repo.

@meteorcloudy meteorcloudy mentioned this pull request Dec 1, 2022
Merged
fweikert pushed a commit that referenced this pull request Dec 1, 2022
@meteorcloudy
Use presubmit.yml from Envoy repo (#1504)
7ea4bc8 
Context:
#1502 (comment)
@keith keith mentioned this pull request Dec 1, 2022
Merged
@keith
Copy link
Copy Markdown
Member Author

keith commented Dec 1, 2022

envoyproxy/envoy#24296

@keith keith closed this Dec 1, 2022
@keith keith deleted the ks/update-clang-version-for-envoy branch December 1, 2022 17:44
fmeum pushed a commit to fmeum/continuous-integration that referenced this pull request Dec 10, 2023
@meteorcloudy @fmeum
Use presubmit.yml from Envoy repo (bazelbuild#1504)
ccc8ca4 
Context:
bazelbuild#1502 (comment)
fweikert pushed a commit to fweikert/continuous-integration that referenced this pull request Mar 27, 2025
@meteorcloudy @fweikert
Use presubmit.yml from Envoy repo (bazelbuild#1504)
74146c0 
Context:
bazelbuild#1502 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fweikert fweikert Awaiting requested review from fweikert fweikert is a code owner

@meteorcloudy meteorcloudy Awaiting requested review from meteorcloudy meteorcloudy is a code owner

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keith @meteorcloudy