Update last green commit from master, stable or main branch and retrieve rules_nodejs .bazelci from stable branch.#1064
Conversation
comius
changed the title
| is_pull_request() | ||
| or use_but | ||
| or os.getenv("BUILDKITE_BRANCH") != "master" | ||
| or (os.getenv("BUILDKITE_BRANCH") != "master" and os.getenv("BUILDKITE_BRANCH") != "stable") |
There was a problem hiding this comment.
While we're here, should be also add the check for main?
There was a problem hiding this comment.
I'd rather wait for the first project to have it. This thing can produce problems if multiple branches are active.
There was a problem hiding this comment.
I see. Yeah, we have to be careful. Looks like rules_pkg has already switched to main - maybe that's a good enough reason?
comius
changed the title
| is_pull_request() | ||
| or use_but | ||
| or os.getenv("BUILDKITE_BRANCH") != "master" | ||
| or (os.getenv("BUILDKITE_BRANCH") != "master" |
There was a problem hiding this comment.
you can merge all three conditions:
... or os.getenv("BUILDKITE_BRANCH) not in ("master", "main", "stable") or ...
There was a problem hiding this comment.
For clarity we should move it out of the first "not" clause, too.
| or (os.getenv("BUILDKITE_BRANCH") != "master" | ||
| and os.getenv("BUILDKITE_BRANCH") != "stable" | ||
| and os.getenv("BUILDKITE_BRANCH") != "main") | ||
| or os.getenv("BUILDKITE_BRANCH") not in ("master", "stable", "main") |
There was a problem hiding this comment.
sorry for yet another late comment, but can you please get rid of the double negation?
There was a problem hiding this comment.
Done, applied de-Morgan laws :)
There was a problem hiding this comment.
Done on the comment as well.
3 participants
rules_nodejs stopped using master and switched to stable branch.
rules_pkg switched to main branch.