Disable warnigns about native rules#952
Merged
vladmos merged 3 commits intobazelbuild:masterfrom Feb 3, 2021
Merged
Conversation
Member
|
cc @comius |
meisterT
approved these changes
Feb 2, 2021
alexeagle
referenced
this pull request
in bazelbuild/rules_apple
May 31, 2021
This warning doesn't seem to hit by default anymore
achew22
pushed a commit
to bazel-contrib/rules_go
that referenced
this pull request
Sep 10, 2021
Long time ago Bazel was saying that cc_binary, cc_library, cc_test and the other cc_* rules should be imported from rules_cc. However rules_cc was always saying that there is no need to use them yet. After several discussions it was clarified that migration to bazelbuild/rules_cc was put on hold and there is not need to the users that they start using it. One of the reasons why a person would not want to use rules_cc right now is because there is no release and there is no notion of what is a good commit: bazelbuild/rules_cc#91 bazelbuild/rules_cc#68 The fact that rules_go depends on rules_cc forces any rules_go user to use rules_cc. Considering that rules_docker depends on rules_go, any rules_docker user is also forced to depend on rules_cc. More information about the discussions: bazelbuild/rules_cc#86 bazelbuild/rules_cc#92 bazelbuild/buildtools#923 bazelbuild/buildtools#952 Fixes: #2949
apattidb
pushed a commit
to databricks/buildtools
that referenced
this pull request
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not clear whether it will be forced to manually load Starlark rules instead of using native rules for android, cc, java, proto, and python. The corresponding warnings are therefore not enabled by default anymore. It's still possible to use them explicitly in buildifier by specifying the required warning categories with the
--warningsflag, e.g.--warnings=native-cc,native-javaor--warnings=+native-android,+native-pyto use all default warnings and some of non-default.Fixes #923.