Classify .BUILD.bazel suffixed files as TypeBuild#1433
Classify .BUILD.bazel suffixed files as TypeBuild#1433oreflow merged 2 commits intobazelbuild:mainfrom
.BUILD.bazel suffixed files as TypeBuild#1433Conversation
Silic0nS0ldier
requested review from
AnnaSvalova
and removed request for
a team
Summary of ChangesHello @Silic0nS0ldier, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces an enhancement to the file type classification system, specifically addressing Bazel-related files. It ensures that any file with a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly adds support for classifying files with a .BUILD.bazel suffix as TypeBuild. The logic is correct. I have one suggestion to improve code consistency. Additionally, it would be great to add a test case for this new pattern in build/lex_test.go to prevent regressions.
Silic0nS0ldier
force-pushed
the
handle-build-bazel-suffixed
branch
from
d600ec4 to
d8f8d98
Compare
oreflow
left a comment
oreflow
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding it :)
2 participants
Updates
getFileTypeto treat*.BUILD.bazelfiles asBUILDfiles, much like*.MODULE.bazel.Resolves #1432.