Add cc attributes for backwards compatibility#1429
Conversation
Summary of ChangesHello @hvadehra, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a potential compatibility issue by restoring specific Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds backwards compatibility for the copts and linkstamp attributes for CC rules, which is a reasonable change. The modification in generatetables/generate_tables.go appears correct. However, the corresponding generated file, lang/tables.gen.go, has not been updated to reflect these changes. This is a critical step to ensure the changes are effective and the project remains in a consistent state.
generatetables/generate_tables.go
Outdated
| // The following attributes used to exist in the native CC rules but were removed | ||
| // during Starlarkification. Add them here for backwards compatibility, at least for now. | ||
| types["copts"] = buildpb.Attribute_STRING_LIST | ||
| types["linkstamp"] = buildpb.Attribute_STRING |
There was a problem hiding this comment.
While adding these attributes for backwards compatibility is correct, the generated file lang/tables.gen.go that depends on this logic has not been updated in this pull request. Please run the update_generated.sh script to apply these changes and commit the updated lang/tables.gen.go file.
2 participants
No description provided.