Add wildcard support for key in dict_replace_if_equal#1426
Merged
oreflow merged 1 commit intobazelbuild:mainfrom Jan 28, 2026
Merged
Add wildcard support for key in dict_replace_if_equal#1426oreflow merged 1 commit intobazelbuild:mainfrom
dict_replace_if_equal#1426oreflow merged 1 commit intobazelbuild:mainfrom
Conversation
oreflow
reviewed
Dec 9, 2025
Collaborator
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds wildcard support for the key in dict_replace_if_equal. The implementation is mostly correct, and the accompanying documentation update is clear. I've identified a couple of areas for improvement: one is a correctness issue regarding the handling of wildcards when no keys match, and the other is a small refactoring to remove redundant code. Overall, a good addition.
mering
force-pushed
the
dict-replace-key-wildcard
branch
from
5768786 to
be9e3b8
Compare
Contributor
Author
|
@oreflow Thanks for the review! I addressed all comments. Can you please take another look? Thanks! |
oreflow
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.