Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

With the release of buildtools 8.5.1 this is now in the wild. These new lints have caught have caught several problems but they've also hit several false positives.

• The /external/ string check includes comment strings. While these can include examples of /external/ (e.g. describing file system layout) they can not affect build behaviour and should be excluded from linting.

  def foo():
      """
      ...
          File("bazel-out/k8-fastbuild/bin/external/rules_pycross++lock_repos+pypi/_lock/[email protected]"),
                                          ^^^^^^^^^^
      ...
      """

• As above, but for @@ in comment strings.
• Not all /external/ substrings refer to the external directory (used by external repositories and may be removed in favour of a sibling layout in the future). For example, a go_library target under a directory called external ends up with an importpath attribute that trips this up.
• The latter is also technically true for @@, although the sequence is rare enough to not be a problem in practise.

Comment strings should be ignored, though I'm not sure how false positives in other places can be avoided (it may well be impossible).