Note that list-append incorrectly warns on select statements#1348
Merged
Note that list-append incorrectly warns on select statements#1348
Conversation
oreflow
reviewed
Apr 3, 2025
oreflow
reviewed
Apr 3, 2025
added 2 commits
April 3, 2025 13:01
vladmos
approved these changes
Apr 3, 2025
oreflow
reviewed
Apr 3, 2025
This was referenced Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buildifier advises authors to use the append function to add singletons to variables.
This works when the variable is a list. If the variable is a select statement, this doesn't work. In this case, the only option is to add a singleton list to the select.