Skip to content

Break module extension groups after a use_repo#1339

Merged
vladmos merged 2 commits intobazelbuild:mainfrom
fmeum:break-use_repo-group
Mar 12, 2025
Merged

Break module extension groups after a use_repo#1339
vladmos merged 2 commits intobazelbuild:mainfrom
fmeum:break-use_repo-group

Conversation

@fmeum
Copy link
Contributor

@fmeum fmeum commented Mar 5, 2025

This allows users to separate tags and associated use_repo statements into separate groups.

Also use unified diffs in the integration tests since ordinary diffs make it very hard to reason about whitespace.

Before:

go_deps = use_extension("//:extensions.bzl", "go_deps")
go_deps.from_file(go_mod = "//:go.mod")
use_repo(
    go_deps,
    "com_github_bazelbuild_buildtools",
)
go_deps.module(name = "foo")
use_repo(go_deps, "foo")

After:

go_deps = use_extension("//:extensions.bzl", "go_deps")
go_deps.from_file(go_mod = "//:go.mod")
use_repo(
    go_deps,
    "com_github_bazelbuild_buildtools",
)

go_deps.module(name = "foo")
use_repo(go_deps, "foo")

This allows users to separate tags and associated `use_repo` statements into separate groups.

Also use unified diffs in the integration tests since ordinary diffs make it very hard to reason about whitespace.

Before:
```
go_deps = use_extension("//:extensions.bzl", "go_deps")
go_deps.from_file(go_mod = "//:go.mod")
use_repo(
    go_deps,
    "com_github_bazelbuild_buildtools",
)
go_deps.module(name = "foo")
use_repo(go_deps, "foo")
```

After:
```
go_deps = use_extension("//:extensions.bzl", "go_deps")
go_deps.from_file(go_mod = "//:go.mod")
use_repo(
    go_deps,
    "com_github_bazelbuild_buildtools",
)

go_deps.module(name = "foo")
use_repo(go_deps, "foo")
```
@fmeum fmeum requested review from pmbethe09 and vladmos as code owners March 5, 2025 09:57
@fmeum
Copy link
Contributor Author

fmeum commented Mar 5, 2025

@Wyverald

@fmeum
Copy link
Contributor Author

fmeum commented Mar 12, 2025

@vladmos

@vladmos vladmos requested a review from oreflow as a code owner March 12, 2025 13:56
@vladmos vladmos merged commit 737aaf8 into bazelbuild:main Mar 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants