Use apparent repo names when fixing loads#1321
Merged
vladmos merged 2 commits intobazelbuild:mainfrom Jan 10, 2025
Merged
Conversation
Whether a load for e.g. proto rules should be from `@com_google_protobuf`, `@protobuf` or a fully custom name depends on the `repo_name` on the `bazel_dep` for the `protobuf` module in the root module's module file. This PR scans `MODULE.bazel` and included `*.MODULE.bazel` files for `bazel_dep`s and uses the derived mapping for the suggested loads.
fmeum
requested review from
larsrc-google,
pmbethe09 and
vladmos
as code owners
Contributor
Author
Contributor
Author
|
FYI @comius |
comius
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether a load for e.g. proto rules should be from
@com_google_protobuf,@protobufor a fully custom name depends on therepo_nameon thebazel_depfor theprotobufmodule in the root module's module file.This PR scans
MODULE.bazeland included*.MODULE.bazelfiles forbazel_deps and uses the derived mapping for the suggested loads.