Merged
Conversation
unused_deps seems to be broken for repositories that have migrated over to bzlmod. Specifically, the reference to the aspect must be done via the canonical name for the workspace now. (This probably even needs to change once WORKSPACE is defunct in Bazel 9) This will break users of unused_deps if they are not on bzlmod but given the latest release of Bazel 8 this is the direction we are headed. Existing WORKSPACE users can pin to a previous version. (Alternatively we could maybe support a flag) fixes bazelbuild#1315
fzakaria
requested review from
larsrc-google,
pmbethe09 and
vladmos
as code owners
Member
|
Please sync to head, that should fix the failing tests. |
vladmos
approved these changes
Dec 12, 2024
Contributor
Author
|
@vladmos clicked the sync button in the UI ... let's see how that goes :) |
This was referenced Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unused_deps seems to be broken for repositories that have migrated over to bzlmod.
Specifically, the reference to the aspect must be done via the canonical name for the workspace now.
(This probably even needs to change once WORKSPACE is defunct in Bazel 9)
This will break users of unused_deps if they are not on bzlmod but given the latest release of Bazel 8 this is the direction we are headed. Existing WORKSPACE users can pin to a previous version. (Alternatively we could maybe support a flag)
fixes #1315