Skip to content

Fix: Buildifier cannot find .buildifier-tables.json when run from a subdirectory#1312

Merged
vladmos merged 8 commits intobazelbuild:mainfrom
dpleshakov:issue_addtables_path
Jan 14, 2025
Merged

Fix: Buildifier cannot find .buildifier-tables.json when run from a subdirectory#1312
vladmos merged 8 commits intobazelbuild:mainfrom
dpleshakov:issue_addtables_path

Conversation

@dpleshakov
Copy link
Contributor

@dpleshakov dpleshakov commented Dec 1, 2024 •
edited
Loading

Fix the issue where Buildifier fails to locate the .buildifier-tables.json file when specifying a relative path in the AddTables configuration and running Buildifier from subdirectories within the workspace. Adding the findTablesPath function similar to the FindConfigPath to search for .buildifier-tables.json.

Fix #1311

@dpleshakov
Fix: Resolve Relative Path Issues for .buildifier-tables.json in AddT…
bb62d34 
…ables Configuration

This commit addresses an issue where Buildifier fails to locate the .buildifier-tables.json file when specifying a relative path in the AddTables configuration and running Buildifier from subdirectories within the workspace.
@dpleshakov dpleshakov marked this pull request as draft December 1, 2024 12:59
@dpleshakov
Copy link
Contributor Author

dpleshakov commented Dec 1, 2024

Does anyone know how to get tests logs from macOS into account the error below?

(14:11:43) INFO: Build Event Protocol files produced successfully.
buildkite-agent artifact upload --content_type=text/plain;encoding=utf-8 buildifier/config/config_test/test_attempts/attempt_1.log
Incorrect Usage: flag provided but not defined: -content_type```

@dpleshakov dpleshakov changed the title Fix issue: Buildifier cannot find .buildifier-tables.json when run from a subdirectory within the workspace. Fix: Buildifier cannot find .buildifier-tables.json when run from a subdirectory Dec 3, 2024
@dpleshakov
Copy link
Contributor Author

dpleshakov commented Dec 3, 2024 •
edited
Loading

Does anyone know how to get tests logs from macOS into account the error below?

(14:11:43) INFO: Build Event Protocol files produced successfully.
buildkite-agent artifact upload --content_type=text/plain;encoding=utf-8 buildifier/config/config_test/test_attempts/attempt_1.log
Incorrect Usage: flag provided but not defined: -content_type```

Ok ,the issue was related to the bazelbuild/continuous-integration release versions 0.2.3 or 0.2.4. There is no error with version 0.2.5 after ff92ddf17592e330b64cfc4fad132eb91190de00. The log of the failed test is successfully attached.

@dpleshakov dpleshakov marked this pull request as ready for review December 3, 2024 19:05
@dpleshakov
Copy link
Contributor Author

dpleshakov commented Dec 12, 2024

@vladmos can you please review it?

@vladmos vladmos merged commit c84efd9 into bazelbuild:main Jan 14, 2025
1 check passed
This was referenced Jan 15, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladmos vladmos vladmos approved these changes

@pmbethe09 pmbethe09 Awaiting requested review from pmbethe09

@larsrc-google larsrc-google Awaiting requested review from larsrc-google

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Buildifier cannot find .buildifier-tables.json when run from a subdirectory within the workspace.

2 participants

@dpleshakov @vladmos