Merged
Conversation
keith
requested review from
larsrc-google,
pmbethe09 and
vladmos
as code owners
Member
Author
|
i don't feel strongly about the defs.bzl part since realistically these rules shouldn't be disabled, but happy to try to go that route and add that upstream to unify this into 1 rule |
keith
force-pushed
the
ks/add-rules_shell-fixing
branch
from
9089c4e to
5445e37
Compare
keith
force-pushed
the
ks/add-rules_shell-fixing
branch
from
5445e37 to
3c92714
Compare
Member
Author
comius
requested changes
Jan 13, 2025
warn/warn_bazel_api.go
Outdated
| if f.Type != build.TypeBzl && f.Type != build.TypeBuild { | ||
| return nil | ||
| } | ||
| return NotLoadedFunctionUsageCheck(f, fileReader, []string{"sh_binary"}, "@rules_shell//shell:sh_binary.bzl") |
Contributor
There was a problem hiding this comment.
Can you move hard coded "@rules_shell//shell:" into tables. See other warnings.
This makes it a bit easier to import, because we're overriding those labels internally.
Member
Author
There was a problem hiding this comment.
ah nice, i skipped that not knowing you were replacing that internally, i should have known! Updated!
Contributor
|
cc @c-mita |
Currently these are split into 3 rules because 1 rule cannot add 3 load statements and this repo doesn't have a defs.bzl that exposes them all
keith
force-pushed
the
ks/add-rules_shell-fixing
branch
from
3c92714 to
ccd4bc9
Compare
comius
approved these changes
Jan 16, 2025
vladmos
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently these are split into 3 rules because 1 rule cannot add 3 load
statements and this repo doesn't have a defs.bzl that exposes them all