Merged
Conversation
keith
requested review from
larsrc-google,
pmbethe09 and
vladmos
as code owners
keith
force-pushed
the
ks/enable-native-rules
branch
from
1cdf802 to
8a55f5e
Compare
Contributor
|
It would be nice if before enabling it again, the Readme of the rules_cc is fixed. |
keith
force-pushed
the
ks/enable-native-rules
branch
from
8a55f5e to
158a320
Compare
Member
Author
|
@comius can you ptal |
Member
Author
With bazel 8.x these should now be loaded externally. It's currently only a soft requirement, but at this point all users should start migrating to this.
keith
force-pushed
the
ks/enable-native-rules
branch
from
158a320 to
76c863b
Compare
Member
Author
|
looks like an infra error with macOS CI here |
Member
Author
|
@vladmos ptal |
comius
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With bazel 8.x these should now be loaded externally. It's currently
only a soft requirement, but at this point all users should start
migrating to this.