perf: Avoid recompiling regexes#1293
Merged
vladmos merged 2 commits intobazelbuild:mainfrom May 27, 2025
Merged
Conversation
dzbarsky
requested review from
larsrc-google,
pmbethe09 and
vladmos
as code owners
|
Example: |
Contributor
Author
|
@vladmos can you please take a look at this one? |
|
@vladmos gentle ping on this one :) |
This was referenced Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can compile these once at package scope instead. This is a slight perf improvement on a medium repo.
I removed some unused code while I was here.