Replace log.Fatalf with log.Exitf to avoid spamming stderr.#1284
Merged
vladmos merged 3 commits intobazelbuild:mainfrom Aug 27, 2024
Merged
Replace log.Fatalf with log.Exitf to avoid spamming stderr.#1284vladmos merged 3 commits intobazelbuild:mainfrom
vladmos merged 3 commits intobazelbuild:mainfrom
Conversation
The set of warnings is something that is changing over time. As scripts tend to hardcode these, they get out of date and we hit this unexpected warning code path. There's little benefit of having a stack trace from this issue. Thus, it's more convenient to just print the error itself and nothing else.
paulherman
requested review from
larsrc-google,
pmbethe09 and
vladmos
as code owners
Member
|
Does it actually make a difference? According to the docs: Fatalf is equivalent to Printf followed by a call to os.Exit(1). https://pkg.go.dev/log#Fatalf |
vladmos
approved these changes
Aug 27, 2024
This was referenced Aug 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set of warnings is something that is changing over time. As scripts tend to hardcode these, they get out of date and we hit this unexpected warning code path. There's little benefit of having a stack trace from this issue. Thus, it's more convenient to just print the error itself and nothing else.