Skip to content

buildifier recursive flag (-r) does not pick up files ending in .BUILD suffix #1136

@cha5on

Description

@cha5on

When using buildifier -r, files ending in the .BUILD suffix do not get included in the checked set of Starlark files. However, this is a somewhat common naming scheme for files in third_party/ folders; see for instance six.BUILD in rules_cc/third_party.

Looking at isStarlarkFile() in utils.go, it looks like this would be the place to add to the list of accepted extensions. Is there some reason it's not already there?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions