Skip to content

buildozer can not add a 'do not sort' comment to deps (so it works) and that makes the result sometimes unusable #1073

@a4z

Description

@a4z

given this example input

cc_library(
    name = "openssl",
    hdrs = glob(["include/**"]),
    includes = ["include"],
    deps = [
        ":ssl_precompiled",  
        ":crypto_precompiled",
    ],
)

running buildozer 'comment deps do\ not\ sort' //openssl produces

cc_library(
    name = "openssl",
    hdrs = glob(["include/**"]),
    includes = ["include"],
    deps = [
        ":crypto_precompiled",
        ":ssl_precompiled",  
    ], # do not sort
)

(please note that sorting has already happened!)

but is should produce

cc_library(
    name = "openssl",
    hdrs = glob(["include/**"]),
    includes = ["include"],
    deps = [ 
        # do not sort
        ":ssl_precompiled",  
        ":crypto_precompiled",
    ], 
)

the comment should be on the rigth position, and deps should not be sorted

I have no idea how I could use buildozer to change some files an prevent deps become sorted, what makes them sometimes unusable

Metadata

Metadata

Assignees

Labels

P1I'll work on this now. (Assignee required)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions