Migrate away from @bazel_tools//src/conditions:host_windows#574
Merged
comius merged 1 commit intobazelbuild:mainfrom Jun 17, 2025
Merged
Migrate away from @bazel_tools//src/conditions:host_windows#574comius merged 1 commit intobazelbuild:mainfrom
@bazel_tools//src/conditions:host_windows#574comius merged 1 commit intobazelbuild:mainfrom
Conversation
The condition has been deprecated at HEAD. None of its usages in skylib were correct as they should all either match on the target or the exec platform, not the host.
fmeum
requested review from
brandjon,
c-mita,
comius,
hvadehra and
tetromino
as code owners
Contributor
Author
|
@katre @meteorcloudy Could you review this for the platform and Windows perspectives? |
meteorcloudy
approved these changes
May 30, 2025
Member
meteorcloudy
left a comment
meteorcloudy
left a comment
There was a problem hiding this comment.
Thank you, approve from Windows perspective!
katre
approved these changes
May 30, 2025
Contributor
katre
left a comment
katre
left a comment
There was a problem hiding this comment.
This is great! @gregestren was looking into this (to get rid of --host_cpu), so thanks for tackling it.
Contributor
Author
|
Friendly ping, would be great to have this merged and released |
Contributor
Author
|
@meteorcloudy @comius Could we get a new skylib release with this fix? https://bazelbuild.slack.com/archives/CA31HN1T3/p1750769722571109 |
Member
|
@fmeum Are you familiar with https://github.com/bazel-contrib/rules-template/blob/main/.github/workflows/release.yaml? Can you help us adopt this workflow for bazel_skylib? |
jaqx0r
added a commit
to jaqx0r/rules_oci
that referenced
this pull request
Aug 11, 2025
Newer versions address a warning about a deprecated feature: bazelbuild/bazel-skylib#574
thesayyn
pushed a commit
to bazel-contrib/rules_oci
that referenced
this pull request
Oct 15, 2025
Newer versions address a warning about a deprecated target: bazelbuild/bazel-skylib#574
rdesgroppes
added a commit
to rdesgroppes/rules_pkg
that referenced
this pull request
Jan 20, 2026
This upgrade of `bazel_skylib` from version 1.7.1 to 1.9.0 eliminates a few deprecation warnings when executing Bazel commands: > WARNING: [...]: target '[...]' depends on deprecated target > '@@bazel_tools//src/conditions:host_windows_x64_constraint': No longer > used by Bazel and will be removed in the future. Migrate to toolchains > or define your own version of this setting. These warnings originated from `bazel_skylib` 1.7.1's use of the deprecated `@bazel_tools//src/conditions:host_windows` constraint in `copy_file` and `diff_test rules`. Sinc version 1.8.0, `bazel_skylib` migrated away from this deprecated constraint (see bazelbuild/bazel-skylib#574).
rdesgroppes
added a commit
to rdesgroppes/rules_pkg
that referenced
this pull request
Jan 20, 2026
This upgrade of `bazel_skylib` from version 1.7.1 to 1.9.0 eliminates a few deprecation warnings when executing Bazel commands: > WARNING: [...]: target '[...]' depends on deprecated target > '@@bazel_tools//src/conditions:host_windows_x64_constraint': No longer > used by Bazel and will be removed in the future. Migrate to toolchains > or define your own version of this setting. These warnings originated from `bazel_skylib` 1.7.1's use of the deprecated `@bazel_tools//src/conditions:host_windows` constraint in `copy_file` and `diff_test rules`. Since version 1.8.0, `bazel_skylib` migrated away from this deprecated constraint (see bazelbuild/bazel-skylib#574).
cgrindel
pushed a commit
to bazelbuild/rules_pkg
that referenced
this pull request
Jan 24, 2026
This upgrade of `bazel_skylib` from version 1.7.1 to 1.9.0 eliminates a few deprecation warnings when executing Bazel commands: > WARNING: [...]: target '[...]' depends on deprecated target > '@@bazel_tools//src/conditions:host_windows_x64_constraint': No longer > used by Bazel and will be removed in the future. Migrate to toolchains > or define your own version of this setting. These warnings originated from `bazel_skylib` 1.7.1's use of the deprecated `@bazel_tools//src/conditions:host_windows` constraint in `copy_file` and `diff_test rules`. Since version 1.8.0, `bazel_skylib` migrated away from this deprecated constraint (see bazelbuild/bazel-skylib#574).
aiuto
pushed a commit
to aiuto/rules_pkg
that referenced
this pull request
Feb 22, 2026
This upgrade of `bazel_skylib` from version 1.7.1 to 1.9.0 eliminates a few deprecation warnings when executing Bazel commands: > WARNING: [...]: target '[...]' depends on deprecated target > '@@bazel_tools//src/conditions:host_windows_x64_constraint': No longer > used by Bazel and will be removed in the future. Migrate to toolchains > or define your own version of this setting. These warnings originated from `bazel_skylib` 1.7.1's use of the deprecated `@bazel_tools//src/conditions:host_windows` constraint in `copy_file` and `diff_test rules`. Since version 1.8.0, `bazel_skylib` migrated away from this deprecated constraint (see bazelbuild/bazel-skylib#574).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The condition has been deprecated at HEAD. None of its usages in skylib were correct as they should all either match on the target or the exec platform, not the host.