adding scope attributes for starlark flags#546
Merged
tetromino merged 14 commits intobazelbuild:mainfrom Oct 30, 2024
aranguyen:main
Merged
adding scope attributes for starlark flags#546tetromino merged 14 commits intobazelbuild:mainfrom aranguyen:main
tetromino merged 14 commits intobazelbuild:mainfrom
aranguyen:main
Conversation
aranguyen
requested review from
brandjon,
c-mita,
comius,
hvadehra and
tetromino
as code owners
Contributor
Author
|
@brandjon @tetromino this is what I've tried to update the docs which shows test failed for //docs:docs_common_settings_doc-difftest FAILED in 2.1s I then proceed with running Is there anything else I need to do? |
tetromino
approved these changes
Oct 30, 2024
mbland
added a commit
to mbland/rules_scala
that referenced
this pull request
Dec 10, 2025
Bumps the minimum `bazel_skylib` version to 1.8.0 and adds `scope = "universal"` to the `@rules_scala_config//:scala_version` build setting. --- The `last_green` BCR builds have been failing since https://buildkite.com/bazel/rules-scala-scala/builds/5916. bazelbuild/bazel@53b7cd8 flipped `--incompatible_exclude_starlark_flags_from_exec_config` to `True`. This stopped the `@rules_scala_config//:scala_version` build setting from propagating to `exec` configurations per bazelbuild/bazel#26909. This caused Bazel to ignore the `scala_version` attribute of `scala_*` rules, causing some targets to break due to incorrect toolchain resolution. Setting `scope = "universal"` on the config setting fixes it, but requires `bazel_skylib` 1.8.0 to support it. This attribute landed in bazelbuild/bazel-skylib@e853fd4 from bazelbuild/bazel-skylib#546. FWIW, `--incompatible_exclude_starlark_flags_from_exec_config` and the `scope` attribute are currently undocumented. See also: - bazelbuild/bazel@9bf10f2 - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/analysis/config/Scope.java - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/skyframe/BuildOptionsScopeFunction.java#L182-L189 - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/analysis/config/CoreOptions.java#L148-L158 - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/analysis/starlark/FunctionTransitionUtil.java#L234-L245
mbland
added a commit
to mbland/rules_scala
that referenced
this pull request
Dec 11, 2025
Bumps the minimum `bazel_skylib` version to 1.8.0 and adds `scope = "universal"` to the `@rules_scala_config//:scala_version` build setting. --- The `last_green` BCR builds have been failing since https://buildkite.com/bazel/rules-scala-scala/builds/5916. bazelbuild/bazel@53b7cd8 flipped `--incompatible_exclude_starlark_flags_from_exec_config` to `True`. This stopped the `@rules_scala_config//:scala_version` build setting from propagating to `exec` configurations per bazelbuild/bazel#26909. This caused Bazel to ignore the `scala_version` attribute of `scala_*` rules, causing some targets to break due to incorrect toolchain resolution. Setting `scope = "universal"` on the config setting fixes it, but requires `bazel_skylib` 1.8.0 to support it. This attribute landed in bazelbuild/bazel-skylib@e853fd4 from bazelbuild/bazel-skylib#546. FWIW, `--incompatible_exclude_starlark_flags_from_exec_config` and the `scope` attribute are currently undocumented. See also: - bazelbuild/bazel@9bf10f2 - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/analysis/config/Scope.java - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/skyframe/BuildOptionsScopeFunction.java#L182-L189 - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/analysis/config/CoreOptions.java#L148-L158 - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/analysis/starlark/FunctionTransitionUtil.java#L234-L245
mbland
added a commit
to bazel-contrib/rules_scala
that referenced
this pull request
Dec 11, 2025
Bumps the minimum `bazel_skylib` version to 1.8.0 and adds `scope = "universal"` to the `@rules_scala_config//:scala_version` build setting. --- The `last_green` BCR builds have been failing since https://buildkite.com/bazel/rules-scala-scala/builds/5916. bazelbuild/bazel@53b7cd8 flipped `--incompatible_exclude_starlark_flags_from_exec_config` to `True`. This stopped the `@rules_scala_config//:scala_version` build setting from propagating to `exec` configurations per bazelbuild/bazel#26909. This caused Bazel to ignore the `scala_version` attribute of `scala_*` rules, causing some targets to break due to incorrect toolchain resolution. Setting `scope = "universal"` on the config setting fixes it, but requires `bazel_skylib` 1.8.0 to support it. This attribute landed in bazelbuild/bazel-skylib@e853fd4 from bazelbuild/bazel-skylib#546. FWIW, `--incompatible_exclude_starlark_flags_from_exec_config` and the `scope` attribute are currently undocumented. See also: - bazelbuild/bazel@9bf10f2 - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/analysis/config/Scope.java - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/skyframe/BuildOptionsScopeFunction.java#L182-L189 - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/analysis/config/CoreOptions.java#L148-L158 - https://github.com/bazelbuild/bazel/blob/ff3d6d0d057064e05f4503f7496ddd5a866bb5c4/src/main/java/com/google/devtools/build/lib/analysis/starlark/FunctionTransitionUtil.java#L234-L245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards https://docs.google.com/document/d/1wIMpW1DsA0CEOs0bo9-maWbNEz4eAAyoIH59lJlZt_o/edit?tab=t.0#heading=h.epjv6353d2y8