{rules_python,rules_python_gazelle_plugin}@1.8.0-rc0#6895
Conversation
|
Hello @rickeylev, @aignas, modules you maintain (rules_python, rules_python_gazelle_plugin) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds version 1.8.0-rc0 for rules_python and rules_python_gazelle_plugin. The changes are mostly correct, but I found a critical dependency issue in rules_python_gazelle_plugin. It declares a dependency on rules_python version 0.18.0 instead of the new version 1.8.0-rc0. This will likely cause breakages for downstream users and must be corrected.
| ) | ||
|
|
||
| bazel_dep(name = "bazel_skylib", version = "1.8.2") | ||
| bazel_dep(name = "rules_python", version = "0.18.0") |
There was a problem hiding this comment.
The rules_python dependency is pinned to 0.18.0, but this release is for 1.8.0-rc0. Since rules_python and rules_python_gazelle_plugin are released from the same repository at the same time, the dependency should be on the same version. The local_path_override in this file and command-line overrides in presubmit.yml mask this issue during CI, but downstream users will fetch the incorrect, older version of rules_python, which will likely cause breakages.
| bazel_dep(name = "rules_python", version = "0.18.0") | |
| bazel_dep(name = "rules_python", version = "1.8.0-rc0") |
|
@bazelbuild/bcr-maintainers looks like we need approval due to presubmit.yaml changes |
fmeum
added
the
presubmit-auto-run
|
@bazelbuild/bcr-maintainers looks like a transient network issue borked the presubmits -- can someone hit rebuild on buildkite? |
|
@bazelbuild/bcr-maintainers can someone please queue for merge? The bot isn't activating for some reason (has all approvals and tests passing). Is it because the PR is draft? Should we create a non-draft PR in the future? |
bazel-io
left a comment
bazel-io
left a comment
There was a problem hiding this comment.
All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.
bazel-io
added
the
auto-merged
4 participants
Release: https://github.com/bazel-contrib/rules_python/releases/tag/1.8.0-rc0
Automated by Publish to BCR