Skip to content
Closed
rickeylev wants to merge 7 commits intobazelbuild:mainfrom
rickeylev:rules.python.gazelle.1.7
Closed

[email protected]#6529
rickeylev wants to merge 7 commits intobazelbuild:mainfrom
rickeylev:rules.python.gazelle.1.7

Conversation

@rickeylev
Copy link
Contributor

This is a manual release of rules_python_gazelle_pluging 1.7.0-rc6 to decouple it from the rules_python release.

@bazel-io
Copy link
Member

Hello @aignas, modules you maintain (rules_python_gazelle_plugin) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@rickeylev
Copy link
Contributor Author

@bazelbuild/bcr-maintainers Can I get the auto-run tag, please? I'd like to iterate to get things passing

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Nov 13, 2025
@rickeylev
Copy link
Contributor Author

@dougthor42 -- the python gazelle plugin is passing except on windows. The error is related to treesitter. ISTR something special is done with treesitter? Any insight? Maybe it's just a wrong version of some dependency being selected?

log excerpt:

external\gazelle~~go_deps~com_github_smacker_go_tree_sitter\iter.go:68:40: undefined: Node
compilepkg: error running subcommand external\rules_go~~go_sdk~go_default_sdk\pkg\tool\windows_amd64\compile.exe: exit status 2

@dougthor42
Copy link

dougthor42 commented Nov 14, 2025

undefined: Node is the same error I was seeing in bazel-contrib/rules_python#2962 (comment)

In that failed PR, One of the things I was trying was to bump go past v1.19. That's when I'd see the undefined: Node error on Windows.

IIRC, gazelle >= 0.40.0 requires rules_go >= 0.50.1 which requires go >= 1.191. So this diff:

-bazel_dep(name = "gazelle", version = "0.36.0", repo_name = "bazel_gazelle")
+bazel_dep(name = "gazelle", version = "0.42.0", repo_name = "bazel_gazelle")

Causes a cascading version update.

Footnotes

  1. N.B.: I haven't done the legwork to figure out the exact versions.

@aignas
Copy link
Contributor

aignas commented Nov 17, 2025

@dougthor42, is there a known workaround around that build failure? To support bazel 9 we'll need to bump the gazelle and rules_go versions anyway.

@dougthor42
Copy link

Migrating to the official go bindings https://github.com/tree-sitter/go-tree-sitter might resolve things.

I can probably spend some time in this coming week to investigate that. Made bazel-contrib/rules_python#3416 to track.

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had any activity for 30 days. It will be closed in 14 days if no further activity occurs. Please comment on this PR to keep it open, or ask @bazelbuild/bcr-maintainers to add the not stale label if it's still relevant.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jan 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

This PR has been closed due to inactivity.

@github-actions github-actions bot closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval stale Issues or PRs that are stale (no activity for 30 days)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants