Update protobuf to have better test config#60
Merged
meteorcloudy merged 1 commit intobazelbuild:mainfrom Jan 11, 2022
Merged
Conversation
Member
Author
|
FYI @fmeum @alexeagle |
alexeagle
approved these changes
Jan 11, 2022
| + | ||
| +local_path_override( | ||
| + module_name = "protobuf", | ||
| + path = "..", |
Contributor
There was a problem hiding this comment.
yeah this seems really nice to me.
fmeum
approved these changes
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the test config for protobuf to use the new matrix testing and bcr test module features.
This change adds more patch for already checked in modules, this should not happen when BCR officially launches, but it's fine for now because we're still in testing phase.