Remove contains() and containsActionResult from SimpleBlobStore#9173
Closed
buchgr wants to merge 1 commit intobazelbuild:masterfrom
Closed
Remove contains() and containsActionResult from SimpleBlobStore#9173buchgr wants to merge 1 commit intobazelbuild:masterfrom
buchgr wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Contributor
Author
|
FYI @borkaehw After this change is in the only change remaining to be able to get a
and
|
buchgr
force-pushed
the
remove-contains
branch
2 times, most recently
from
ddad4b7 to
d84d58a
Compare
contains() and containsActionResult() only make sense for the OnDiskBlobStore because they can be implemented with a (quickly returning) stat() call. They are not generally useful for remote caching/execution. Thus this change moves them down to the OnDiskBlobStore. In the same breath I removed any non-test uses of the InMemoryBlobStore and moved the class to the test package. The InMemoryBlobStore has never been used by Bazel itself but only by its tests and the LRE. The LRE usage has never really made sense either and so I removed it from there as well.
buchgr
force-pushed
the
remove-contains
branch
from
d84d58a to
3eaee65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
contains() and containsActionResult() only make sense for the OnDiskBlobStore
because they can be implemented with a (quickly returning) stat() call. They are
not generally useful for remote caching/execution. Thus this change
moves them down to the OnDiskBlobStore.
In the same breath I removed any non-test uses of the InMemoryBlobStore
and moved the class to the test package. The InMemoryBlobStore has never
been used by Bazel itself but only by its tests and the LRE. The LRE
usage has never really made sense either and so I removed it from there
as well.