Refactor GrpcRemoteCache to use uploadFile and uploadBlob.#9039
Closed
buchgr wants to merge 1 commit intobazelbuild:masterfrom
Closed
Refactor GrpcRemoteCache to use uploadFile and uploadBlob.#9039buchgr wants to merge 1 commit intobazelbuild:masterfrom
buchgr wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Contributor
Author
|
I like the plan we discuss here #9028 (comment), just wondering are all the works going to happen in this single PR? |
The methods have the same signature as the ones in SimpleBlobStore. This gets us one step closer to merging AbstractRemoteActionCache and SimpleBlobStoreActionCache.
buchgr
force-pushed
the
refactor-upload
branch
from
b6c7dad to
ed5719d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods have the same signature as the ones in SimpleBlobStore. This gets us one step closer to merging AbstractRemoteActionCache and SimpleBlobStoreActionCache.