Refactor SimpleBlobStore#put#9028
Closed
buchgr wants to merge 3 commits intobazelbuild:masterfrom
Closed
Conversation
Contributor
Author
|
Do we have an ETA for this PR? |
|
If we're removing |
Contributor
Author
|
@SrodriguezO the plan is for the The do the following renames:
|
|
Ah that makes sense. Sounds great! Thanks for clarifying |
ishikhman
reviewed
Aug 2, 2019
Contributor
ishikhman
left a comment
ishikhman
left a comment
There was a problem hiding this comment.
thanks for this refactoring!
a few notes from me below.
Split it into SimpleBlobStore#uploadFile and SimpleBlobStore#uploadBlob. The return type changes to ListenableFuture<Void> but all implementations are still blocking for now. This will be changed in a follow up CL. This is a refactoring towards the larger goal of removing SimpleBlobStoreActionCache and making GrpcRemoteCache a SimpleBlobStore implementation. The idea is for AbstractRemoteActionCache#upload(ActionResult, ...) to no longer be abstract but instead to call out to abstract uploadFile and uploadBlob methods (just like downloadBlob).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split it into
SimpleBlobStore#uploadFileandSimpleBlobStore#uploadBlob.The return type changes to
ListenableFuture<Void>but allimplementations are still blocking for now.
This is a refactoring towards the larger goal of removing
SimpleBlobStoreActionCacheand making GrpcRemoteCache a SimpleBlobStore implementation.